-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Span Operations for Audit #694
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
55b6ae1
to
fe692c1
Compare
fe692c1
to
9c4b41d
Compare
d586131
to
44a1459
Compare
@AbhiPrasad I talked to @stayallive, and we're happy with
for Laravel 👍 |
@AbhiPrasad out of curiosity, why is the convention |
It's because the action for the |
@AbhiPrasad that's what I figured, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AbhiPrasad and @jan-auer
We're now merging this - we can continue to iterate on this as needed. |
https://www.notion.so/sentry/Set-up-an-audit-for-SDK-consistency-for-span-operations-to-enable-performance-issues-addf02a8fa234dda8acf48d4ff9b8efb?d=b852bdd1e9914d2ca74c1052296081f3#d04af01302604881999b1bd29c837b1f
This PR attempts to align our span operations based on an audit we've taken on in the past 2 weeks. The reason we are trying to align our span operations is because they are required to generate consistent performance issues: getsentry/sentry#37083
In addition, to this PR, we've collected a list of span operations we'll need to update across the different SDKs: #693 (comment)