Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont set lastEventId for transactions #431

Closed
1 task done
marandaneto opened this issue Sep 9, 2021 · 5 comments
Closed
1 task done

Dont set lastEventId for transactions #431

marandaneto opened this issue Sep 9, 2021 · 5 comments

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Sep 9, 2021

lastEventId could be used for reporting a userfeedback, so we cant assign the lastEventId for transactions

Spec PR https://github.com/getsentry/develop/pull/430/files

Have to change in all the SDKs that do it

  • Dart
@marandaneto
Copy link
Contributor Author

@maciejwalkowiak can you check the Java SDK, please?
@brustolin the iOS SDK has to change too.
@bruno-garcia .NET SDK as well
@rhcarvalho for Web SDKs
I'm gonna do it for Flutter

@kamilogorek
Copy link
Contributor

@bruno-garcia
Copy link
Member

The .NET SDK already works as intended. A test to validate the behavior was added: getsentry/sentry-dotnet#1191

@kamilogorek
Copy link
Contributor

Go: getsentry/sentry-go#379

@bruno-garcia
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants