Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set lastEventId for transactions #61

Closed
5 of 6 tasks
romtsn opened this issue Oct 14, 2022 · 8 comments
Closed
5 of 6 tasks

Don't set lastEventId for transactions #61

romtsn opened this issue Oct 14, 2022 · 8 comments

Comments

@romtsn
Copy link
Member

romtsn commented Oct 14, 2022

lastEventId could be used for reporting a userfeedback, so we cant assign the lastEventId for transactions

Spec: https://develop.sentry.dev/sdk/performance/#hub-changes

See getsentry/develop#431 for more details

@brustolin
Copy link

brustolin commented Oct 17, 2022

Cocoa don't have lastEventId.
Is this something we should have?

@romtsn
Copy link
Member Author

romtsn commented Oct 17, 2022

we set it for captureEvent captureException captureMessage, I guess thats where we could add it, if not yet

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Dec 6, 2022

RN was missing the function. It was accessible only indirectly thru the hub. I'm waiting for a new JS release to test the feature. But we don't change the JS logic and that one is correct.

@kahest
Copy link
Member

kahest commented Feb 17, 2023

we set it for captureEvent captureException captureMessage, I guess thats where we could add it, if not yet

@philipphofmann @brustolin Do we need this?

@kahest
Copy link
Member

kahest commented Feb 17, 2023

RN was missing the function. It was accessible only indirectly thru the hub. I'm waiting for a new JS release to test the feature. But we don't change the JS logic and that one is correct.

@krystofwoldrich Have you been able to test this?

@brustolin
Copy link

@philipphofmann @brustolin Do we need this?

We probably do.

@krystofwoldrich
Copy link
Member

@kahest Yes, it works correctly, ot doesn't set the id for transactions.

@kahest
Copy link
Member

kahest commented Feb 20, 2023

@philipphofmann @brustolin Do we need this?

We probably do.

Created getsentry/sentry-cocoa#2705 for discussion.

Closing this issue since everything is done. 👍

@kahest kahest closed this as completed Feb 20, 2023
@philipphofmann philipphofmann changed the title Dont send lastEventId for transactions Don't set lastEventId for transactions Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants