crashpad_handler: add response body to error log if status is not OK #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in case the response status is not 200. This is important, because if the crashpad-handler receives an 400 (Bad Request) for whichever reason, it will detail why in the response-body. This helps customers and us to figure out why the minidump endpoint negates requests from the crashpad-handler in case this happens.
Swatinem
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important because if the
crashpad_handlerreceives a 400 (Bad Request) for whichever reason fromrelay, it will detail why in the response body. This helps identify the cause of the rejection.I am open to suggestions for further logs if you have any, but I think this covers the most immediate needs. Everything else would require access to the minidump or envelope, right?