fix: upload crashes on linux

[BogdanLivadariu]

as per description and comments on: getsentry/sentry-native#773

[BogdanLivadariu]

tested changes with a custom build of sentry-native on the latest release(0.5.3) and crashes do get uploaded now on linux hosts

[Swatinem]

I believe you have to find / declare libcurl as a dependency to crashpad now.
For sentry-native that just works as it depends on curl itself already.

[Swatinem]

You also have to add the found curl package to the dependencies :-)

@supervacuus can help you with that

[supervacuus]

Hi @BogdanLivadariu, thanks for starting this off.

[supervacuus]

@BogdanLivadariu, are you planning to finish this PR?

[BogdanLivadariu]

Hi @supervacuus
I would ... but my experience with cmake is not at its best, if you could guide me on where to
add the found curl package to the dependencies that would be great

[supervacuus]

@BogdanLivadariu, you can start by applying my change suggestions, which do most of the work. I just saw that I forgot to request them.

[BogdanLivadariu]

hi @supervacuus does this looks good to go ?
should I squash the commits ?

thanks for the suggestions

[supervacuus]

LGTM @BogdanLivadariu; no need to squash, we will do this. Thx!

[supervacuus]

@Swatinem, can I ask you to merge this?

[bsergean]

Could we do the if(NOT CURL_FOUND) around the find_package trick ?

https://github.com/bsergean/crashpad/pull/1/files

[supervacuus]

Could we do the if(NOT CURL_FOUND) around the find_package trick ?

There is no "trick" involved :-) This is how FindCURL is supposed to work in layered CMake projects. A few other changes are also needed before we update the submodule in the Native SDK, which I will finish today.

[bsergean]

Ok great. For context we are using the breakpad backend now, but it would be nice to be able to use the crashpad one, because it feels more robust in case of an early crash. We are calling our binary twice from a shell script (a second time in ‘reporting mode’ where we exit right after we’ve uploaded a potential crash). In environments like Kubernetes, it can be hard to have access to the same sentry database path the 'second time'

…

On Jan 24, 2023, at 10:56 PM, Mischan Toosarani-Hausberger ***@***.***> wrote: Could we do the if(NOT CURL_FOUND) around the find_package trick ? There is no "trick" involved :-) This is how FindCURL is supposed to work in layered CMake projects. A few other changes are also needed before we update the submodule in the Native SDK, which I will finish today. — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UIHXZN4O2N5QQ2WJBTWUDFCFANCNFSM6AAAAAASZCQGTQ>. You are receiving this because you commented.