feat: crashpad cxx17 support #116
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crashpad increasingly depends on C++20 features through its base-library `mini_chromium`. This change vendors a `mini_chromium` fork that is compatible with C++17 compilers and removes the dependency on `std::ranges` in the `crashpad` uuid utilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crashpad increasingly depends on C++20 features through its base-library
mini_chromium.This change vendors a
mini_chromiumfork compatible with C++17 compilers and removes the dependency onstd::rangesin thecrashpadUUID utilities.The corresponding
mini_chromiumchange is: getsentry/mini_chromium#1This change is based on upstream
mini_chromiumrevision bd56f6 which is also thegetsentrybranch-base of our fork.