Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSSQL OBDC driver to v18 #6968

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented May 14, 2024

What type of PR is this?

  • Other

Description

Move back to 18 after reverting the build

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Not tested

Related Tickets & Documents

#6967

@eradman eradman requested a review from justinclift May 14, 2024 15:07
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

All of the other important pieces from the MSSQL ODBC version bump a few weeks ago (#6924) still seem to be present in our codebase, so this should be all that's needed.

@justinclift justinclift merged commit 408ba78 into getredash:master May 14, 2024
11 checks passed
@eradman eradman deleted the mssql-odbc branch May 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants