Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync .nvmrc with workflow #6958

Merged
merged 1 commit into from
May 10, 2024
Merged

sync .nvmrc with workflow #6958

merged 1 commit into from
May 10, 2024

Conversation

ehooi
Copy link
Contributor

@ehooi ehooi commented May 10, 2024

What type of PR is this?

  • Other

Description

sync .nvmrc with workflow file's node.js version

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (4569191) to head (bd3c25b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6958   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files         161      161           
  Lines       13094    13094           
  Branches     1814     1814           
=======================================
  Hits         8359     8359           
  Misses       4432     4432           
  Partials      303      303           

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. 😄

@justinclift justinclift merged commit 1b946b5 into getredash:master May 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants