Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: Improve Glacier URL routing #7688

Merged
merged 1 commit into from
May 13, 2024

Conversation

bblommers
Copy link
Collaborator

Behaviour is exactly the same, just with a simplified URL routing.

@bblommers bblommers added this to the 5.0.8 milestone May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.32%. Comparing base (de19a6c) to head (f77e4de).

Files Patch % Lines
moto/glacier/responses.py 98.07% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7688   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files        1087     1087           
  Lines       92692    92648   -44     
=======================================
- Hits        87434    87394   -40     
+ Misses       5258     5254    -4     
Flag Coverage Δ
servertests 29.41% <26.22%> (+<0.01%) ⬆️
unittests 94.29% <98.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit db97004 into getmoto:master May 13, 2024
40 checks passed
@bblommers bblommers deleted the techdebt/glacier-urls branch May 13, 2024 18:35
Copy link
Contributor

This is now part of moto >= 5.0.8.dev2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant