-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAFv2: Add support for IP sets and logging configuration #7680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @pinzon!
It looks like the mypy
check is failing:
https://github.com/getmoto/moto/actions/runs/8992773456/job/24703301155
I also think that for most of these types, we would have to use the mypy
-version instead of the builtin-type - i.e. List[Dict[str, Any]]
instead of list[dict[str, any]]
. As far as I know, the builtin types are only supported in more recent Python versions, and we still support 3.8.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7680 +/- ##
========================================
Coverage 94.29% 94.29%
========================================
Files 1086 1087 +1
Lines 92356 92557 +201
========================================
+ Hits 87090 87281 +191
- Misses 5266 5276 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thank you @pinzon!
This is now part of moto >= 5.0.7.dev37 |
This pull request introduces support for IP Sets and Logging configurations resources within the WAFv2 service. It includes the implementation of new operations:
Additionally, two CRUD tests have been added for these resources. These tests have been successfully executed against AWS without any complications.
Partially addresses localstack/localstack#10558