RouteTables: Filter by route.nat-gateway-id #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7677 +/- ##
==========================================
- Coverage 94.29% 94.29% -0.01%
==========================================
Files 1087 1087
Lines 92397 92399 +2
==========================================
+ Hits 87127 87128 +1
- Misses 5270 5271 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
May 8, 2024
There was a problem hiding this comment.
Great - thank you for the PR @yoelsusanto, and welcome to Moto!
|
This is now part of moto >= 5.0.7.dev35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In my work, we do DescribeRouteTables and filter by
route.nat-gateway-id. However, it is currently not implemented yet and returns the following error:Changes
route.nat-gateway-id