Feature: EMR Serverless job runs #7671
Conversation
| @@ -706,27 +706,37 @@ | |||
|
|
|||
| ## bedrock | |||
| <details> | |||
| <summary>65% implemented</summary> | |||
There was a problem hiding this comment.
These implementation coverage reports were all updated by the implementation_coverage.py script.
| @@ -6,9 +6,9 @@ | |||
| class ResourceNotFoundException(JsonRESTError): | |||
| code = 400 | |||
|
|
|||
| def __init__(self, resource: str): | |||
| def __init__(self, resource: str, resource_type: str = "Application"): | |||
There was a problem hiding this comment.
Added for compatibility with JobRun resources
|
Working on getting the CI pipeline passing. There are a few more checks than I realized. |
|
Ok, all CI tests are passing now |
fix: Changed default state of job runs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7671 +/- ##
==========================================
+ Coverage 94.29% 94.32% +0.02%
==========================================
Files 1086 1087 +1
Lines 92356 92669 +313
==========================================
+ Hits 87090 87412 +322
+ Misses 5266 5257 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fix: added 100% code coverage
fix: fixed pre-python3.11 fromisoformat() issue
There was a problem hiding this comment.
LGTM - thank you so much for contributing to Moto @kgmcquate!
The existing EMR Serverless implementation has Applications implemented, but not Job Runs on those Applications. This PR adds those.
There are also some minor changes, like typos or copy/paste mistakes.