Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS: create_platform_endpoint() is idempotent, if without attributes … #7635

Merged

Conversation

bblommers
Copy link
Collaborator

…supplied

Fixes #7609

@bblommers bblommers added this to the 5.0.6 milestone Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (e51192b) to head (dd8c460).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7635   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files        1082     1082           
  Lines       92267    92267           
=======================================
+ Hits        87003    87004    +1     
+ Misses       5264     5263    -1     
Flag Coverage Δ
servertests 29.41% <ø> (ø)
unittests 94.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit e72c9a5 into getmoto:master Apr 27, 2024
40 checks passed
@bblommers bblommers deleted the sns-duplicate-default-platform-endpoint branch April 27, 2024 21:12
Copy link
Contributor

This is now part of moto >= 5.0.6.dev43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNS: create_platform_endpoint is not idempotent with default attributes
1 participant