Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces: Fix directory type #7625

Merged
merged 6 commits into from May 6, 2024

Conversation

archinksagar
Copy link
Contributor

Changed the directory type of workspace directories from lowercase to Uppercase. This is for describe_workspace_directories api call.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/workspaces/client/describe_workspace_directories.html

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the linter is failing @archinksagar.

Just a hunch - are you using black? As we've recently switched to ruff, so the fix would be:

ruff format moto/workspaces
ruff check --fix moto/workspaces

@archinksagar
Copy link
Contributor Author

@bblommers I tried using ruff, but it did not change anything

Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.29%. Comparing base (4a2ed3b) to head (9657bf9).
Report is 17 commits behind head on master.

Files Patch % Lines
moto/workspaces/models.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7625      +/-   ##
==========================================
- Coverage   94.30%   94.29%   -0.01%     
==========================================
  Files        1086     1086              
  Lines       92394    92296      -98     
==========================================
- Hits        87128    87029      -99     
- Misses       5266     5267       +1     
Flag Coverage Δ
servertests 29.47% <0.00%> (+0.02%) ⬆️
unittests 94.26% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @archinksagar, I reverted the formatting changes, that fixed the build.

Thank you for the PR!

@bblommers bblommers changed the title Fix/directory type Workspaces: Fix directory type May 6, 2024
@bblommers bblommers added this to the 5.0.7 milestone May 6, 2024
@bblommers bblommers merged commit fa52c54 into getmoto:master May 6, 2024
39 of 40 checks passed
Copy link
Contributor

github-actions bot commented May 6, 2024

This is now part of moto >= 5.0.7.dev33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants