New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspaces: Fix directory type #7625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the linter is failing @archinksagar.
Just a hunch - are you using black? As we've recently switched to ruff
, so the fix would be:
ruff format moto/workspaces
ruff check --fix moto/workspaces
@bblommers I tried using ruff, but it did not change anything |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7625 +/- ##
==========================================
- Coverage 94.30% 94.29% -0.01%
==========================================
Files 1086 1086
Lines 92394 92296 -98
==========================================
- Hits 87128 87029 -99
- Misses 5266 5267 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @archinksagar, I reverted the formatting changes, that fixed the build.
Thank you for the PR!
This is now part of moto >= 5.0.7.dev33 |
Changed the directory type of workspace directories from lowercase to Uppercase. This is for describe_workspace_directories api call.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/workspaces/client/describe_workspace_directories.html