Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panorama: Add more features about nodes #7623

Merged

Conversation

YHallouard
Copy link
Contributor

No description provided.

@YHallouard YHallouard force-pushed the feat/panorama_add_more_features_about_nodes branch from 8e6bbae to 383ce73 Compare April 23, 2024 08:19
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (9aef694) to head (9cc6133).
Report is 201 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7623      +/-   ##
==========================================
- Coverage   95.88%   94.24%   -1.64%     
==========================================
  Files         843     1072     +229     
  Lines       82578    92284    +9706     
==========================================
+ Hits        79178    86973    +7795     
- Misses       3400     5311    +1911     
Flag Coverage Δ
servertests 29.42% <24.48%> (-3.10%) ⬇️
unittests 94.21% <100.00%> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YHallouard YHallouard force-pushed the feat/panorama_add_more_features_about_nodes branch from 383ce73 to e57d90f Compare April 23, 2024 08:53
@YHallouard YHallouard force-pushed the feat/panorama_add_more_features_about_nodes branch from e57d90f to 9cc6133 Compare April 24, 2024 08:32
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @YHallouard!

@bblommers bblommers added this to the 5.0.7 milestone Apr 29, 2024
@bblommers bblommers merged commit 95a1959 into getmoto:master Apr 29, 2024
39 of 40 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.7.dev5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants