Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DeletionProtectionEnabled to dynamoDB #7619

Merged
merged 4 commits into from Apr 29, 2024

Conversation

Wolgo
Copy link
Contributor

@Wolgo Wolgo commented Apr 22, 2024

Adds the DeletionProtectionEnabled parameter to DynamoDB.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (1988b91) to head (e18e9db).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7619   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files        1082     1082           
  Lines       92267    92284   +17     
=======================================
+ Hits        87004    87021   +17     
  Misses       5263     5263           
Flag Coverage Δ
servertests 29.41% <23.52%> (-0.01%) ⬇️
unittests 94.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for adding this to Moto @Wolgo!

@bblommers bblommers added this to the 5.0.7 milestone Apr 29, 2024
@bblommers bblommers merged commit 83fbc7e into getmoto:master Apr 29, 2024
40 checks passed
@Wolgo Wolgo deleted the feature-deletion-protection-dynamodb branch April 29, 2024 18:15
Copy link
Contributor

This is now part of moto >= 5.0.7.dev4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants