New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sagemaker-Metrics: Add sagemaker metrics #7617
Sagemaker-Metrics: Add sagemaker metrics #7617
Conversation
e614c1c
to
9d2ea8e
Compare
Hi, I put a lot of cast inside my PR and I'm don't very like it... Do you prefer using cast, "# type: ignore", a Typed Dict (but will force typing_extension for old python version), a pydantic model or create a Metric Object ? |
9d2ea8e
to
e5cf1af
Compare
e5cf1af
to
4e445d7
Compare
Hi @bblommers, I hope you're doing well :) I'm a little bit lost, my test suite is failing on test server. I can replicate it on local, it seems that the sagemaker metrics backend is not created in server mode. Do you have any idea ? |
4aed72c
to
fb1f726
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7617 +/- ##
==========================================
- Coverage 95.88% 94.30% -1.58%
==========================================
Files 843 1086 +243
Lines 82578 92452 +9874
==========================================
+ Hits 79178 87187 +8009
- Misses 3400 5265 +1865
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The routing needed some additional logic to deal with the multiple Sagemaker services - that's fixed now.
LGTM - thanks @YHallouard!
Wow, tricky ! Thank you very much for the help ! You rock ! @bblommers |
No description provided.