S3: Days must not be provided for select request when restoring object
#7468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
reviewed
Mar 14, 2024
moto/s3/responses.py
Outdated
| @@ -2272,10 +2272,19 @@ def _key_response_post( | |||
| ) | |||
|
|
|||
| elif "restore" in query: | |||
| es = minidom.parseString(body).getElementsByTagName("Days") | |||
| days = es[0].childNodes[0].wholeText | |||
| params = minidom.parseString(body) | |||
There was a problem hiding this comment.
Is there any value in using xmltodict here? We use it somewhere else in this file as well.
I don't know what the output for that would look like, but maybe it's easier than parsing the XML manually.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7468 +/- ##
==========================================
- Coverage 95.88% 95.81% -0.08%
==========================================
Files 843 854 +11
Lines 82578 84012 +1434
==========================================
+ Hits 79178 80492 +1314
- Misses 3400 3520 +120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Mar 15, 2024
|
This is now part of moto >= 5.0.4.dev16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DaysandTypeparameters exist in restore object request.https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3/client/restore_object.html
related: #7467