Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPCEndpoint: add state filtering #7449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoenkeD
Copy link
Contributor

@SoenkeD SoenkeD commented Mar 9, 2024

AWS EC2 endpoint support filtering by the endpoints state ( https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeVpcEndpoints.html ). It seems, that only a mapping of the objects value to the filter was missing.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SoenkeD, would you mind adding a test for this?

There is an existing test for the other filter, in tests/test_ec2/test_vpcs.py::test_describe_vpc_gateway_end_points, so we can just extend that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants