Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Sending notification to EventBridge OBJECT_CREATED_COMPLETE_MULTIPART_UPLOAD_EVENT #7435

Conversation

tsugumi-sys
Copy link
Contributor

@tsugumi-sys tsugumi-sys commented Mar 7, 2024

  • Sending a notification to EventBridge when multipart upload is completed.
  • Unittest is added.

related #7363

@tsugumi-sys tsugumi-sys force-pushed the send-s3-eventbridge-notification-CompleteMultipartUpload branch from e1c53fe to 48ec93d Compare March 7, 2024 10:34
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tsugumi-sys!

The current implementation tries to send two notifications - one for CompleteMultiupload, and one for PutObject.

I've pushed a change to the complete_multipart-method so that all the logic is in one place - if you could pull in the latest changes from master, you'll see that it will make controlling the notifications a bit easier.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (9aef694) to head (32088ce).
Report is 83 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7435      +/-   ##
==========================================
- Coverage   95.88%   95.80%   -0.08%     
==========================================
  Files         843      849       +6     
  Lines       82578    83692    +1114     
==========================================
+ Hits        79178    80181    +1003     
- Misses       3400     3511     +111     
Flag Coverage Δ
servertests 32.30% <0.00%> (-0.22%) ⬇️
unittests 95.77% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @tsugumi-sys!

@bblommers bblommers added this to the 5.0.3 milestone Mar 8, 2024
@bblommers bblommers merged commit 4fc45e7 into getmoto:master Mar 8, 2024
39 checks passed
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This is now part of moto >= 5.0.3.dev55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants