Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM: Allow CF to delete InstanceProfile with existing role #7431

Merged

Conversation

bblommers
Copy link
Collaborator

See #7381

@bblommers bblommers added this to the 5.0.3 milestone Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (9aef694) to head (9a6e5b9).
Report is 75 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7431      +/-   ##
==========================================
- Coverage   95.88%   95.77%   -0.11%     
==========================================
  Files         843      849       +6     
  Lines       82578    83618    +1040     
==========================================
+ Hits        79178    80086     +908     
- Misses       3400     3532     +132     
Flag Coverage Δ
servertests 32.30% <33.33%> (-0.23%) ⬇️
unittests 95.74% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 95e183b into getmoto:master Mar 6, 2024
39 checks passed
@bblommers bblommers deleted the iam-allow-cf-to-delete-instance-profiles branch March 6, 2024 22:22
Copy link
Contributor

github-actions bot commented Mar 6, 2024

This is now part of moto >= 5.0.3.dev46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant