Winter 2022 build update

[nyonson]

1. Define internal package dependencies in package.jsons, use a tool to sync to tsconfig
   • https://github.com/azu/monorepo-utils can sync yarn ⇒ ts (package.json to tsconfig.json), including the root solutions tsconfig.json
     • Q: do we still need solutions config paths? Mike reports it helps IDE’s autocomplete so we might have to update by hand to keep that functionality
2. Move test script to package level
   • package test script is something like tsc --build && jest
     • leverages tsc’s build performance
   • to test monorepo yarn workspaces foreach --topological --parallel run test
     • leverages yarns build performance with parallel and topology flags
   • add new code coverage reporter like https://github.com/ScaCap/code-coverage-assistant
3. Move lint script to package level
   • package lint script is something like tsc --build && lint
     • leverages tsc’s build performance
   • to test monorepo yarn workspaces foreach --topological --parallel run lint
     • leverages yarns build performance with parallel and topology flags
4. Define all dependencies on the leaf package level
   • Only actual root level tasks are defined in root (e.g. yarn release), foreach scripts are defined at the leaf package instead of relying on the yarn script wrapper pattern
5. Only support ESM packages
   • package type module
   • need to use .js extension in import statements

TODO

• do not publish test files
• test importing from mash
• add back paths if necessary

[mdedys]

This should probably be in each package now.

[nyonson]

hm, yea, not sure why it got added here

[github-actions]

Coverage after merging into main

client-sdk	73.06%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
IFrame.ts	82.35%	93.75%	96.24%	151, 152, 153, 239, 240, 241, 243, 243, 280, 295, 304
Mash.ts	0%	0%	0%	10, 107, 11, 18, 18, 19, 20, 21, 22, 26, 26, 27, 28, 31, 33, 34, 35, 37, 40, 41, 43, 46, 57, 57, 59, 6, 61, 62, 69, 77, 78, 78, 79, 8, 81, 82, 92, 92, 93, 97, 98
settings.ts	100%	100%	100%
src/rpc
RPCApi.ts	0%	0%	0%	35, 38, 38, 44, 48, 55, 59, 63, 67, 69, 7, 7, 7, 8
methods.ts	100%	100%	0%	1
targets.ts	100%	100%	0%	1

jsonrpc-engine	96.67%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
JsonRPC.ts	100%	100%	100%
JsonRPCEngine.ts	80%	100%	96%	63, 65, 66

post-message	100.00%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
PostMessageEngine.ts	91.30%	100%	100%	47, 84

[mdedys]

Just some high level items:

• Can we update npmignore files to exclude the tests, eslint, tsconfig, and jest config.
• Confirm monorepo works correctly
• Add changeset to up the versions of packages.

[mdedys]