Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docs repo subpath ignored #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: docs repo subpath ignored #95

wants to merge 1 commit into from

Conversation

james-d-elliott
Copy link

Summary

This fixes an issue where the docsRepoSubPath option is ignored. This was caused due to a refactoring moving the docsRepoSubPath option under the doks key.

Basic example

N/A

Motivation

This option does nothing currently as the two checks are inconsistent.

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

@james-d-elliott
fix: docs repo subpath ignored
33d0fd5 
This fixes an issue where the docsRepoSubPath option is ignored. This was caused due to a refactoring moving the docsRepoSubPath option under the doks key.
h-enk
h-enk approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@h-enk h-enk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM /thanks! Related: do you see time available to take up #57

@james-d-elliott
Copy link
Author

Yeah I think I can do that pretty easily.

@h-enk
Copy link
Member

h-enk commented Mar 4, 2024

That would be great!

@h-enk h-enk added this to the v1.5 milestone Mar 5, 2024
@h-enk h-enk added the bug Something isn't working label Mar 5, 2024
@h-enk h-enk removed this from the v1.5 milestone Mar 6, 2024
@salim-b salim-b mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-enk h-enk h-enk approved these changes

Assignees

@james-d-elliott james-d-elliott

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@james-d-elliott @h-enk