refactor(uuid): [noticket]: Replace uuid package with generateId util

[diogomateus]

What this PR does

Replaces uuid package with a custom and simpler generateId util.

Why is this needed?

uuid package can't be tree-shaked and was adding a giant additional size to repos where it was being imported.
Usually, using random for random ids is not the most efficient way but since this ids are not persistent and used for runtime only (generate label/input ids, temporary ids for error entries) this downgrade from uuid might make sense.

Named the util generateId so it doesn't suggest it is a fully and standardised uuid and replaces the function.
The id generated is based on a random number that is then parsed into an hex string for each of the characters.

Checklist:

• I reviewed my own code
• The changes align with the designs I received
  Or give a reason why this does not apply:
• I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
  Or give a reason why this does not apply:
• I have updated the task(s) status on Linear
• All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

• Firefox
• Chrome
• Safari
• Edge

[diogomateus]

@everyone I'm very open to other proposals regarding this refactoring.

[talo242]

Not sure if it'd be worth it to write regression tests for the format xxxx-xxxx-xxx-xxxx and/or length of the string? (only if it's relevant)

[diogomateus]

You mean regression as a way to make sure it's compatible with previous usages or for future proof?

[kimkwanka]

Instead of cooking up our own solution here which, in theory, could still produce identical ids, would maybe using https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID be an alternative here? It looks like browser support is solid

[diogomateus]

Seems like randomUUID runs into a lot of issues and is only available in secure contexts meaning we might run into some issues using it. On top of that it's only available on node v19 and we're running on v16 which means it triggers errors when building storybook.

Updated it to use this function by broofa that is one of the contributors to the uuid library and, I believe, part of the team that implemented randomUUID.

Still defaulting to Math random for places where we might run into an issue. Testing should be one those cases.

[kimkwanka]

Seems like randomUUID runs into a lot of issues and is only available in secure contexts meaning we might run into some issues using it. On top of that it's only available on node v19 and we're running on v16 which means it triggers errors when building storybook.

Updated it to use this function by broofa that is one of the contributors to the uuid library and, I believe, part of the team that implemented randomUUID.

Still defaulting to Math random for places where we might run into an issue. Testing should be one those cases.

That's a shame, but I guess that's all that can be done at this point. Thanks 👍

[diogomateus]

Seems like randomUUID runs into a lot of issues and is only available in secure contexts meaning we might run into some issues using it. On top of that it's only available on node v19 and we're running on v16 which means it triggers errors when building storybook.
Updated it to use this function by broofa that is one of the contributors to the uuid library and, I believe, part of the team that implemented randomUUID.
Still defaulting to Math random for places where we might run into an issue. Testing should be one those cases.

That's a shame, but I guess that's all that can be done at this point. Thanks 👍

100%, pretty annoying that we have to go through such hassle just to create an ID when there's even a function already for it 😅

[broofa]

uuid package can't be tree-shaked

Can you elaborate on this? The uuid module was refactored a while back precisely to facillitate tree-shaking, so this comment is a little surprising.

[kimkwanka]

uuid package can't be tree-shaked

Can you elaborate on this? The uuid module was refactored a while back precisely to facillitate tree-shaking, so this comment is a little surprising.

@diogomateus

[diogomateus]

uuid package can't be tree-shaked

Can you elaborate on this? The uuid module was refactored a while back precisely to facillitate tree-shaking, so this comment is a little surprising.

After digging up a bit, I think this might be related to the fact that we were using the v0.8.3 instead of the most recent one where the minified UMD build was removed so there shouldn't be an issue with it. I'll take a look and try to replicate it again later and let you know of what I find.