Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 0conf channels #69

Merged
merged 24 commits into from
Mar 19, 2024
Merged

feat: support 0conf channels #69

merged 24 commits into from
Mar 19, 2024

Conversation

rolznz
Copy link
Collaborator

@rolznz rolznz commented Feb 29, 2024

Fixes #119

Notes:

  • Voltage LSP has been disabled for now (it just doesn't show in the list)
  • All payments will be deleted when you first update, since we do not migrate old payment entries in the LDK database

TODOs:

  • Working with Voltage - get peer's feerate is much too low (waiting for response from LDK - seems to only happen on mempool spikes)
  • Working with Zeus
    • Why did I need to restart my node and re-pair to un-stuck the wrapped invoice payment? - probably event handling issues?
    • Sent logs of rare occurrence where LDK node got stuck at one point when receiving open channel message
    • Why do I need to re-pair after restarting the node? - LDK bug (fixed)
  • update ldk-node-go library once anchor support PR is merged
  • update keysend to listen to ldk payment events
  • undo hacks in the code
    • consume from ldk-node-go
      • mac support
    • ldk storage path
    • description
    • expiry
  • move 0conf channel creation to UI (similar to what was planned with Blocktank)
  • move event handling and payment reason fixes to separate PR
  • run an Alby esplora service - esplora issues seem to cause delays and unexpected behavior here? moved to separate issue
  • add migration to delete old LDK payments (they are incompatible)

@rolznz rolznz mentioned this pull request Mar 16, 2024
@rolznz rolznz marked this pull request as ready for review March 17, 2024 06:41
@rolznz rolznz changed the title feat: support 0conf channels (WIP) feat: support 0conf channels Mar 17, 2024
@rolznz rolznz merged commit 67f4b56 into master Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDK SendKeysend does not wait for success/failure event
1 participant