feat: add export account #1012
Merged
feat: add export account #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapedcat
suggested changes
Jun 9, 2022
| @@ -195,6 +236,70 @@ function AccountsScreen() { | |||
| </div> | |||
| </form> | |||
| </Modal> | |||
|
|
|||
There was a problem hiding this comment.
@dylancom you think by now we should move out these two modals into separate component-files?
im-adithya
force-pushed
the
task-export-wallet
branch
2 times, most recently
from
51f34b4
to
a40a024
Compare
bumi
reviewed
Jun 11, 2022
bumi
approved these changes
Jun 13, 2022
im-adithya
force-pushed
the
task-export-wallet
branch
from
65282a3
to
c093d7c
Compare
escapedcat
reviewed
Jun 15, 2022
bumi
approved these changes
Jun 16, 2022
im-adithya
force-pushed
the
task-export-wallet
branch
from
61d8ed7
to
f6ebb49
Compare
|
Ready! |
|
Please fix conflicts. You think we should move the modals in to a separate file(s)? |
im-adithya
force-pushed
the
task-export-wallet
branch
from
f6ebb49
to
22257bf
Compare
|
The |
bumi
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
we should add i18n (@im-adithya maybe we do this in a new PR?)
Sure! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Introduces Export option in the accounts list.
Link this PR to an issue
Closes #669
Type of change (Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes (If any)
If we have lightning address:
If we don't:
Add screenshots to help explain your problem
How has this been tested?
Ran all tests
Checklist