Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #51

Merged
merged 2 commits into from Aug 25, 2019
Merged

update dependencies #51

merged 2 commits into from Aug 25, 2019

Conversation

gesellix
Copy link
Owner

Beware before merging: there's an issue in urfave/cli 1.21.0: urfave/cli#850

Beware before merging: there's an issue in urfave/cli 1.21.0: urfave/cli#850
@gesellix
Copy link
Owner Author

Build log:

# github.com/gesellix/couchdb-prometheus-exporter/fileutil
fileutil/properties_file_loader.go:69:25: cannot use MapInputSource literal (type *MapInputSource) as type altsrc.InputSourceContext in return argument:
	*MapInputSource does not implement altsrc.InputSourceContext (wrong type for Generic method)
		have Generic(string) ("github.com/gesellix/couchdb-prometheus-exporter/vendor/gopkg.in/urfave/cli.v1".Generic, error)
		want Generic(string) ("github.com/gesellix/couchdb-prometheus-exporter/vendor/github.com/urfave/cli".Generic, error)

@coilysiren
Copy link

coilysiren commented Aug 25, 2019

I'm pretty sure this error message ...

# github.com/gesellix/couchdb-prometheus-exporter/fileutil
fileutil/properties_file_loader.go:69:25: cannot use MapInputSource literal (type *MapInputSource) as type altsrc.InputSourceContext in return argument:
	*MapInputSource does not implement altsrc.InputSourceContext (wrong type for Generic method)
		have Generic(string) ("github.com/gesellix/couchdb-prometheus-exporter/vendor/gopkg.in/urfave/cli.v1".Generic, error)
		want Generic(string) ("github.com/gesellix/couchdb-prometheus-exporter/vendor/github.com/urfave/cli".Generic, error)

... is caused by this bit here

-have Generic(string) (".../vendor/gopkg.in/urfave/cli.v1".Generic, error)
+want Generic(string) (".../vendor/github.com/urfave/cli".Generic, error)

Find and replace gopkg.in/urfave with github.com/urfave and see if that works?

@gesellix
Copy link
Owner Author

Hey @lynncyrin, thanks for that official support by a maintainer :)
Your hint seems to be the fix, thanks a lot!

@gesellix
Copy link
Owner Author

gesellix commented Aug 25, 2019

Hm. Now the Docker build fails, but this seems to be unrelated:

--- FAIL: TestSemaphore (0.02s)
couchdb-client_test.go:30: Workers did not complete in time
FAIL
FAIL	github.com/gesellix/couchdb-prometheus-exporter/lib	0.288s

edit: the Docker Hub build has succeeded.

@gesellix gesellix merged commit eb2c1e9 into master Aug 25, 2019
@gesellix gesellix deleted the dep-upd branch August 25, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants