Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autofocus for Login form #9359

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavGoeck
Copy link
Contributor

Description

The username input field is now automatically focussed when opening the Login modal if the corresponding configuration option is enabled.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@DavGoeck
Copy link
Contributor Author

As a first attempt at a PR, I'd like to have the Login Form be in focus automatically. While I would want this to be enabled by default I have written it so that it has to be enabled via configuration option in the localConfig.json.
The issue I have is that I don't know an elegant way of loading the config value into the Plugin. Suggestions are welcome!

@tdipisa tdipisa added this to the 2023.02.01 milestone Sep 1, 2023
@tdipisa tdipisa removed this from the 2023.02.01 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants