Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10070 - Fix: Scroll bars for legend widgets won't move coherently with displayed data #10329

Merged
merged 1 commit into from
May 16, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented May 16, 2024

Description

This PR adds a handler (easily discardable when fix in plotly.js is implemented) to control mouse wheel sensitivity and normalizes the deltaY so that it seamless across browsers

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

scroll_dynamic.mp4

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C027-COMUNE_FI-2023-SUPPORT labels May 16, 2024
@dsuren1 dsuren1 added this to the 2024.01.01 milestone May 16, 2024
@dsuren1 dsuren1 requested a review from allyoucanmap May 16, 2024 07:07
@dsuren1 dsuren1 self-assigned this May 16, 2024
@dsuren1 dsuren1 linked an issue May 16, 2024 that may be closed by this pull request
1 task
@allyoucanmap allyoucanmap merged commit 3234b9a into geosolutions-it:master May 16, 2024
6 checks passed
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test on dev and let us know if we can backport on 2024.01.xx, thanks

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport on 2024.01.xx, thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request May 16, 2024
…e coherently with displayed data (geosolutions-it#10329)

(cherry picked from commit 3234b9a)
dsuren1 added a commit that referenced this pull request May 16, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll bars for legend widgets won't move coherently with displayed data
4 participants