#10264: Fix - Layer visibility limits may prevent the Info panel of search results from opening #10325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anel of search results from opening [resolve review comments] Description: - edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits - handle showing feature info in case of search within single layer or All layers
…anel of search results from opening [resolve review comments] Description: - handle showing feature info in case of action in queryParameters
6 tasks
…anel of search results from opening [resolve review comments] Description: - add missing check on the layer with ignoring visibility limits of making sure it is queryable - fix FE failure test
dsuren1
changed the title
dsuren1
changed the title
dsuren1
requested changes
May 16, 2024
web/client/epics/search.js
Outdated
| if (!queryableLayersIgnoreingVisiblimits && layer && defaultQueryableFilter(layer)) { | ||
| queryableLayers = [...queryableLayers, layer]; | ||
| } | ||
| const isLayerNotQueryableSelected = queryableLayers.filter(l => l.name === name ).length === 0; |
There was a problem hiding this comment.
Suggested change
| const isLayerNotQueryableSelected = queryableLayers.filter(l => l.name === name ).length === 0; | |
| const isLayerNotQueryableSelected = queryableLayers.filter(l => l.name === name).length === 0; |
…anel of search results from opening [resolve review comments] Description: - add unit tests - fix handling search for layers has visibility limits
…anel of search results from opening [resolve review comments] Description: - fix unit test
dsuren1
requested changes
May 17, 2024
There was a problem hiding this comment.
@mahmoudadel54
Kindly amend this and we should be good to merge
…anel of search results from opening [resolve review comments] Description: - add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits' - edit unit test based on the change
dsuren1
approved these changes
May 17, 2024
dsuren1
added
BackportNeeded
|
@ElenaGallo Kindly test it in DEV and let us know if it's good to be backported. Thanks! |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
May 20, 2024
…Info panel of search results from opening (geosolutions-it#10325) * geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits - handle showing feature info in case of search within single layer or All layers * geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - handle showing feature info in case of action in queryParameters * geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add missing check on the layer with ignoring visibility limits of making sure it is queryable - fix FE failure test * geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add unit tests - fix handling search for layers has visibility limits * geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - fix unit test * geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits' - edit unit test based on the change
Backport is done --- > #10345 |
tdipisa
pushed a commit
that referenced
this pull request
May 20, 2024
… Info panel of search results from opening (#10302, #10325) (#10345) * #10264: Layer visibility limits may prevent the Info panel of search results from opening (#10302) * #10264: Layer visibility limits may prevent the Info panel of search results from opening Description: - isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem' - write unit test for that * Update web/client/epics/search.js --------- Co-authored-by: Suren <dsuren1@gmail.com> * #10264: Fix - Layer visibility limits may prevent the Info panel of search results from opening (#10325) * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits - handle showing feature info in case of search within single layer or All layers * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - handle showing feature info in case of action in queryParameters * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add missing check on the layer with ignoring visibility limits of making sure it is queryable - fix FE failure test * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add unit tests - fix handling search for layers has visibility limits * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - fix unit test * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits' - edit unit test based on the change --------- Co-authored-by: Suren <dsuren1@gmail.com>
ElenaGallo
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10264
What is the current behavior?
#10264
What is the new behavior?
If the layer has a limited visibility like showing features from a specific scale level, and user searches for an existing feature into the searched layer while the hidden scale level ---> if the feature is existing, it will open the info panel showing the feature info data
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information