Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10272: Choice of OGC service type for single layer in CSW catalog #10304

Merged
merged 3 commits into from
May 16, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented May 10, 2024

Description

This PR gives the ability for the user to choose which service type, when the records has support for multi OGC service in the dc references, to be used when adding a layer to map via catalog of service type 'csw'

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?
User can choose the service from which the layer to be added to Map.

Note

Currently support only WFS as the additional OGC service

image
wfs_csw.mp4

Note

TEST DATA
https://gn3-rndt.geo-solutions.it/geonetwork/srv/eng/csw (Layer name - unesco)
https://geobretagne.fr/geonetwork/srv/fre/csw (many records has multiple ogc service)

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C027-COMUNE_FI-2023-SUPPORT labels May 10, 2024
@dsuren1 dsuren1 added this to the 2024.01.01 milestone May 10, 2024
@dsuren1 dsuren1 requested a review from offtherailz May 10, 2024 11:11
@dsuren1 dsuren1 self-assigned this May 10, 2024
@dsuren1 dsuren1 linked an issue May 10, 2024 that may be closed by this pull request
@dsuren1 dsuren1 enabled auto-merge (squash) May 10, 2024 11:32
@tdipisa tdipisa requested review from MV88 and removed request for offtherailz May 10, 2024 12:13
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of comments with some jsdoc

web/client/api/CSW.js Show resolved Hide resolved
web/client/api/catalog/CSW.js Show resolved Hide resolved
web/client/api/catalog/CSW.js Show resolved Hide resolved
web/client/api/catalog/WFS.js Show resolved Hide resolved
web/client/components/catalog/RecordItem.jsx Show resolved Hide resolved
@dsuren1 dsuren1 requested a review from MV88 May 16, 2024 07:43
@dsuren1 dsuren1 merged commit d033bc7 into geosolutions-it:master May 16, 2024
6 checks passed
@MV88
Copy link
Contributor

MV88 commented May 16, 2024

@ElenaGallo please test in DEV

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2024.01.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request May 16, 2024
MV88 pushed a commit that referenced this pull request May 16, 2024
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choice of type of OGC service for single layer in CSW catalog
3 participants