-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10225: Enhance UX for simple 3D navigation in touch devices [Implementation via Config-level] #10261
#10225: Enhance UX for simple 3D navigation in touch devices [Implementation via Config-level] #10261
Conversation
Description: - Add some cfg for cesium mapOptions to enhance UX of navigation - Handle disable tilt effect - Handle enabling zoom limits max, min or both - Handle enabling fixing orientation of the map scene - Handle enabling hiding the compass ui widget - Handling quick reset to the initial camera scene stored into map object
…evices [resolve review comments] Description: - remove unused/unnecessary code based on code reviews - edit zoom to initial view button to enable zoom to camera view - edit translations of the label of zoomAll plugin - rename zoomDistance map options + edit jsDoc
…evices [resolve review comments] Description: - fix FE failure by update a unit test of ZoomToMaxExtentButton
…evices [resolve review comments] Description: - edit translation in en-US
@ElenaGallo please test on dev and let us know if we can backport to 2024.01.xx, thanks |
Hi @ElenaGallo The results of this PR you can test [they are just 2 things]:
For the rest points mentioned on the issue description, they may be in separate future issues. |
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
…evices [Implementation via Config-level] (geosolutions-it#10261)
Description
In this PR, the required enhancements are implemented but within the config-level by adding some cfg for cesium mapOptions to enhance UX of navigation.
In includes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10225
What is the current behavior?
#10225
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
There are 2 notes need to highlighted:
1- For the point
Quick reset of the 3D map view (the camera view) to restore the initial state
, I have checked the implementation of zoomToExtent button and I found out as an enhancement for 3D mode only, we can pass the viewerOptions object - that includes orientation and destination objects - to the zoomTo action which will do the same required functionality.But If the required logic is keeping zoomTo extent implementation as it is currently and extending the functionality by adding the new functionality in a separate place, it is Ok.
2- For the point of
fix camera orientation limits and/or fixed camera orientation
, When I enable fix camera orientationenableFixedOrientation: true
anddisableTilt = true
, the tilt doesn't disable.It enables the tilt effect by default. so there will be conflict between disabling tilt and fix camera orientation.