Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10026: Interactive legend for TOC layers [Vector layer part] #10188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahmoudadel54
Copy link
Collaborator

Description

In this PR, interactive legend functionality for WMS/WFS layers is implemented. User can configure enabling the interactive legend for vector layer from display tab in layer settings. Legend filter will be reset if user change the style and user can reset it manually by clicking on the selected filter legend again to remove the legend filter.

This PR includes:

  • Adding interactive legend for vector layers
  • Add checkbox for enable the interactive legend for vector into layer settings
  • handle the logic of filter by legend for vector layer in case of 2d openlayer map and 3d cesium map
  • write unit tests based on code changes

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10026

What is the current behavior?
#10026

What is the new behavior?
User can add vector layer and enable the interactive legend to enable him/her to filter the layer if user change style that includes filter expressions like classification style for example.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…r part]

- Adding interactive legend for vector layers
- Add checkbox for enable the interactive legend for wfs and vector into layer settings and for the catalog as well [just for wfs]
- handle the logic of filter by legend for vector layer in case of 2d openlayer map and 3d cesium map
- write unit tests based on code changes
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.02 milestone Apr 11, 2024
@mahmoudadel54 mahmoudadel54 self-assigned this Apr 11, 2024
@mahmoudadel54 mahmoudadel54 linked an issue Apr 11, 2024 that may be closed by this pull request
6 tasks
@mahmoudadel54 mahmoudadel54 marked this pull request as ready for review April 11, 2024 09:15
@tdipisa tdipisa modified the milestones: 2024.01.02, 2024.02.00 Apr 11, 2024
@tdipisa tdipisa removed a link to an issue Apr 29, 2024
6 tasks
@tdipisa tdipisa linked an issue Apr 29, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive legend for TOC layers
2 participants