Add localized aria-labels to glyph buttons #10161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 4, 2024 13:38
Modify tooltip enhancer to also provide `aria-label`-property to wrapped objects (most commonly glyph-only buttons). Does localization on a best-effort basis, trying to unwrap messages passed in as tooltip prop. On Behalf of DB Systel
Use accessible tooltip enhancer in Locate, Redo, Undo, Zoom and Toggle button components On Behalf of DB Systel
…tton This required adding some new text to the translation dictionaries. On Behalf of DB Systel
1 task
|
@fkellner thank you so much for your contribution. We will review as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MapStore uses a lot of glyph-only buttons with text tooltips. While these tooltips provide
text for the buttons via
aria-labeledbyproperties, they are only effective when the tooltipsare being rendered (and the id tying them together is often broken).
This PR proposes a change to the
tooltipenhancer, which adds the tooltip text asaria-labelto the wrapped buttons.It also refactors some buttons to also use the
tooltipenhancer, and adds localizedaria-labelsto a few glyph buttons without tooltip.
We would be interested in your opinion whether this is a small enough change to accept, or
whether it introduces unnecessary complexity. However, this is not a high priority issue.
What kind of change does this PR introduce?
Issue
What is the current behavior?
#10158
What is the new behavior?
Most glyph buttons now have a reliably present, localized
aria-label.Breaking change
Does this PR introduce a breaking change?
Other useful information
Messagecomponent passed astooltipprop are read out. Maybe this is a little "hacky".ButtonWithTooltipcomponent) wherever possible seems like a sensible refactoring whether you like thearia-labelchange or not. If you do not want to merge this PR, I could do a new one just with this commit.