geosolutions-it#6913: grid cards keyboard navigation #10150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes grid cards keyboard navigable and accessible again On Behalf of DB Systel
tdipisa
added
enhancement
BackportNeeded
|
@fkellner thank you so much for your contribution. We will review as soon as possible. |
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes grid cards keyboard navigable and accessible again (with tab + enter,
you can reach a map now).
Does not change how anything looks for non-keyboard users.
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#6913 Reaching a map only using the keyboard is impossible.
Power users and people with motoric impairments often prefer
to navigate a website using the keyboard rather than the mouse.
What is the new behavior?
The grid cards, which represent buttons to maps, now can be focused
via keyboard and pressed via Enter button.
Breaking change
Other useful information
Tests only include the "clicking with the Enter button" behaviour, since the testing framework does not seem to
support side effects like focusing elements with the tab button.