Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer visibility limits may prevent the Info panel of search results from opening #10264

Closed
1 of 6 tasks
tdipisa opened this issue Apr 29, 2024 · 0 comments · Fixed by #10302, #10325 or #10345
Closed
1 of 6 tasks

Layer visibility limits may prevent the Info panel of search results from opening #10264

tdipisa opened this issue Apr 29, 2024 · 0 comments · Fixed by #10302, #10325 or #10345
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted C206-DEUTSCHE_BAHN-2024-SUPPORT enhancement
Milestone
2024.01.01

Comments

@tdipisa
Copy link
Member

tdipisa commented Apr 29, 2024

Description

we figured out, that the info panel wont open correctly for a selected search result, even if the map zooms correctly to the selected object.

How to reproduce

  1. Configure the visibility limits of the states of us like that:
    image

  2. Configure the search options by editing the Search configuration for the us_states:
    image

  3. Zoom out to a large scale so the US States are not visible for the current scale
    image

  4. Search for any us state (e.g. Alabama)
    image

Expected Result

The warning is initially irritating as the search result can be found correctly. The layer is active and queryable after the zoom. Furthermore, it is more user-friendly if the visibility limits doesn't have be checked before searching for an object.

Current Result

The map zoom changes to the search result as expected but a popup appears informing the user there are no queryable layers and the Identify panel doesn't open

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

The solution we are foreseeing here is to:

  • Trigger the identify process only after the zoom operation
  • Make the 'disabled' state of the layer in this case not blocking for the identify process when it is triggered by a search operation: this just to cover cases when the zoom is not enough to visualize a certain feature according to the visibility limits configured
@tdipisa tdipisa added this to the 2024.01.01 milestone Apr 29, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned dsuren1 May 3, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 10, 2024
@mahmoudadel54
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
063a1be 
…anel of search results from opening

Description:
- isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem'
- write unit test for that
@mahmoudadel54 mahmoudadel54 mentioned this issue May 10, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request May 10, 2024 that will close this issue
#10264: Layer visibility limits may prevent the Info panel of search results from opening #10302
Merged
12 tasks
dsuren1 added a commit that referenced this issue May 10, 2024
@mahmoudadel54 @dsuren1
#10264: Layer visibility limits may prevent the Info panel of search …
2acf717 
…results from opening (#10302)

* #10264: Layer visibility limits may prevent the Info panel of search results from opening
Description:
- isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem'
- write unit test for that

* Update web/client/epics/search.js

---------

Co-authored-by: Suren <dsuren1@gmail.com>
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 13, 2024
@ElenaGallo ElenaGallo self-assigned this May 13, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 15, 2024
@mahmoudadel54
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
77ecf1d 
…anel of search results from opening [resolve review comments]

Description:
- edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits
- handle showing feature info in case of search within single layer or All layers
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 15, 2024
@mahmoudadel54
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
8ee69e0 
…anel of search results from opening [resolve review comments]

Description:
- handle showing feature info in case of action in queryParameters
@mahmoudadel54 mahmoudadel54 mentioned this issue May 15, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request May 15, 2024 that will close this issue
#10264: Fix - Layer visibility limits may prevent the Info panel of search results from opening #10325
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 15, 2024
@mahmoudadel54
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
741590b 
…anel of search results from opening [resolve review comments]

Description:
- add missing check on the layer with ignoring visibility limits of making sure it is queryable
- fix FE failure test
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 17, 2024
@mahmoudadel54
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
f5eeb32 
…anel of search results from opening [resolve review comments]

Description:
- add unit tests
- fix handling search for layers has visibility limits
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 17, 2024
@mahmoudadel54
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
6420fc1 
…anel of search results from opening [resolve review comments]

Description:
- fix unit test
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 17, 2024
@mahmoudadel54
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
ede14d0 
…anel of search results from opening [resolve review comments]

Description:
- add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits'
- edit unit test based on the change
dsuren1 pushed a commit that referenced this issue May 17, 2024
@mahmoudadel54
#10264: Fix - Layer visibility limits may prevent the Info panel of s…
13fe763 
…earch results from opening (#10325)

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits
- handle showing feature info in case of search within single layer or All layers

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- handle showing feature info in case of action in queryParameters

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add missing check on the layer with ignoring visibility limits of making sure it is queryable
- fix FE failure test

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add unit tests
- fix handling search for layers has visibility limits

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- fix unit test

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits'
- edit unit test based on the change
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 20, 2024
@mahmoudadel54 @dsuren1
geosolutions-it#10264: Layer visibility limits may prevent the Info p…
ffcbd56 
…anel of search results from opening (geosolutions-it#10302)

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening
Description:
- isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem'
- write unit test for that

* Update web/client/epics/search.js

---------

Co-authored-by: Suren <dsuren1@gmail.com>
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 20, 2024
@mahmoudadel54
geosolutions-it#10264: Fix - Layer visibility limits may prevent the …
7bf0464 
…Info panel of search results from opening (geosolutions-it#10325)

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits
- handle showing feature info in case of search within single layer or All layers

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- handle showing feature info in case of action in queryParameters

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add missing check on the layer with ignoring visibility limits of making sure it is queryable
- fix FE failure test

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add unit tests
- fix handling search for layers has visibility limits

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- fix unit test

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits'
- edit unit test based on the change
@mahmoudadel54 mahmoudadel54 mentioned this issue May 20, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request May 20, 2024 that will close this issue
[Backport 2024.01.xx] #10264: Layer visibility limits may prevent the Info panel of search results from opening (#10302, #10325) #10345
Merged
tdipisa pushed a commit that referenced this issue May 20, 2024
@mahmoudadel54 @dsuren1
[Backport 2024.01.xx] #10264: Layer visibility limits may prevent the…
721b6af 
… Info panel of search results from opening (#10302, #10325) (#10345)

* #10264: Layer visibility limits may prevent the Info panel of search results from opening (#10302)

* #10264: Layer visibility limits may prevent the Info panel of search results from opening
Description:
- isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem'
- write unit test for that

* Update web/client/epics/search.js

---------

Co-authored-by: Suren <dsuren1@gmail.com>

* #10264: Fix - Layer visibility limits may prevent the Info panel of search results from opening (#10325)

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits
- handle showing feature info in case of search within single layer or All layers

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- handle showing feature info in case of action in queryParameters

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add missing check on the layer with ignoring visibility limits of making sure it is queryable
- fix FE failure test

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add unit tests
- fix handling search for layers has visibility limits

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- fix unit test

* #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits'
- edit unit test based on the change

---------

Co-authored-by: Suren <dsuren1@gmail.com>
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted C206-DEUTSCHE_BAHN-2024-SUPPORT enhancement
Projects
None yet
Milestone
2024.01.01
4 participants
@tdipisa @dsuren1 @ElenaGallo @mahmoudadel54