Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG Accessibility Improvements - Low Hanging Fruits #10158

Open
1 task done
fkellner opened this issue Apr 4, 2024 · 0 comments · May be fixed by #10159 or #10161
Open
1 task done

WCAG Accessibility Improvements - Low Hanging Fruits #10158

fkellner opened this issue Apr 4, 2024 · 0 comments · May be fixed by #10159 or #10161
Assignees

Comments

@fkellner
Copy link
Contributor

fkellner commented Apr 4, 2024

Description

image

Running the MapStore dashboard through Lighthouse currently yields a bad accessibility score of 62, and the
map view does not score much better (66). As a german company using MapStore, we are required by law to
put some effort into the accessibility of public facing websites.

Some changes that we did to improve the score are relatively painless and trivial, others, especially relating
to the labelling of buttons, introduce some small overhead. So, I will provide two PRs with our changes:

  • One with the tiny changes that should not be an issue with the rest of the code (like setting document language, alt tag for logo), but already improve the score considerably
  • One with the more complicated changes (mainly button labels with i18n).

I hope the first one should not be a problem for you to merge, but the second one I am interested in your feedback, but it is not a high priority enhancement.

A small accessibility issue in the navbar is currently caused by a react-bootstrap-Component, once you move on to the next major version, it should be fixed.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information

fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible than
disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming
into the map using browser zoom should be able to notice the actual controls and recover from their mistake.

On Behalf of DB Systel
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
- Convert heading that, semantically, should not be a heading, to a div
- correctly assign label to scalebox
- add alt tag to attribution logo

On Behalf of DB Systel
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible than
disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming
into the map using browser zoom should be able to notice the actual controls and recover from their mistake.

On Behalf of DB Systel
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
- Convert heading that, semantically, should not be a heading, to a div
- correctly assign label to scalebox
- add alt tag to attribution logo

On Behalf of DB Systel
@fkellner fkellner linked a pull request Apr 4, 2024 that will close this issue
2 tasks
@tdipisa tdipisa linked a pull request Apr 4, 2024 that will close this issue
2 tasks
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
Modify tooltip enhancer to also provide `aria-label`-property to wrapped objects
(most commonly glyph-only buttons). Does localization on a best-effort basis, trying
to unwrap messages passed in as tooltip prop.

On Behalf of DB Systel
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
Use accessible tooltip enhancer in Locate, Redo, Undo, Zoom and Toggle button components

On Behalf of DB Systel
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 4, 2024
…tton

This required adding some new text to the translation dictionaries.

On Behalf of DB Systel
@fkellner fkellner linked a pull request Apr 4, 2024 that will close this issue
2 tasks
@tdipisa tdipisa linked a pull request Apr 4, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant