Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade spotless-maven-plugin to latest version supporting git worktree checkouts #5816

Merged
merged 1 commit into from Apr 16, 2022

Conversation

groldan
Copy link
Member

@groldan groldan commented Apr 15, 2022

Upgrading spotless 2.20.0 to 2.20.21, which supports
git worktree checkouts as of diffplug/spotless#1119.

2.20.0 fails with an exception like the following for each module:

[INFO] --- spotless-maven-plugin:2.20.0:apply (default) @ geoserver---
[ERROR] /git/geoserver/main/.git/config: Not a directory
java.nio.file.FileSystemException: /home/groldan/git/geoserver/geoserver/master/.git/config: Not a directory
    at sun.nio.fs.UnixException.translateToIOException (UnixException.java:100)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:111)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:116)

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

…ee checkouts

Upgrading spotless 2.20.0 to 2.20.21, which supports
`git worktree` checkouts.

2.20.0 fails with an exception like the following for each module:

```
[INFO] --- spotless-maven-plugin:2.20.0:apply (default) @ geoserver---
[ERROR] /git/geoserver/main/.git/config: Not a directory
java.nio.file.FileSystemException: /home/groldan/git/geoserver/geoserver/master/.git/config: Not a directory
    at sun.nio.fs.UnixException.translateToIOException (UnixException.java:100)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:111)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:116)
```
@groldan groldan requested a review from aaime April 15, 2022 15:15
@aaime
Copy link
Member

aaime commented Apr 15, 2022

Seems ok.

@groldan groldan merged commit 590ce54 into geoserver:main Apr 16, 2022
@groldan groldan deleted the build/spotless-maven-plugin-upgrade branch April 16, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants