update bindgen to fix incorrect proj results on apple silicon #80
Conversation
michaelkirk
changed the title
|
Should we also regenerate https://github.com/georust/proj/blob/master/proj-sys/src/bindings_docs-rs.rs? |
|
Excellent observation, thank you @lnicola. done! |
|
|
||
| pub const PROJ_VERSION_MAJOR: u32 = 7; | ||
| pub const PROJ_VERSION_MINOR: u32 = 1; | ||
| pub const PROJ_VERSION_PATCH: u32 = 0; | ||
| pub const PROJ_VERSION_MINOR: u32 = 2; |
There was a problem hiding this comment.
Docs were actually not updated last time we updated libproj.
|
Can I do this? bors r+ It would be really nice to not require |
|
🔒 Permission denied Existing reviewers: click here to make lnicola a reviewer |
There was a problem hiding this comment.
It would be really nice to not require bindgen as it's a heavy dependency. gdal-sys actually has some pre-built bindings for this. But now I wonder how portable those bindings actually are.
I'm with you. #44
I think we're onboard. Just no-one has done it yet.
🔒 Permission denied
I've just now added you! Can you try again?
| #[doc = " error_string_max_size should be the maximum size that can be written into"] | ||
| #[doc = " the out_error_string buffer (including terminating nul character)."] | ||
| #[doc = ""] | ||
| #[doc = " @return the number of bytes actually read (0 in case of error)"] |
There was a problem hiding this comment.
I don't really follow bindgen dev, but seems to be extracting mostly useful comments from the C source now, which is neat.
There was a problem hiding this comment.
See also rust-lang/rust-bindgen#1265
There was a problem hiding this comment.
lol you're EVERYWHERE.
There was a problem hiding this comment.
Yeah, I ran into that in georust/gdal#55.
|
bors r+ |
|
Build succeeded: |
FIXES #52