Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.70, 1.71 to CI, bump MSRV to 1.65 #1067

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add 1.70, 1.71 to CI, bump MSRV to 1.65 #1067

merged 1 commit into from
Sep 25, 2023

Conversation

michaelkirk
Copy link
Member

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

1.65 was released more than 10 months ago: https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html

Notably (for me anyway because I keep trying to use it) this means we can use let/else syntax.

As a reminder, our policy has been to support at least the last 6 months (STABLE + 3 prior), but I usually bump it conservatively to whatever feature is causing annoyance.

@michaelkirk
Copy link
Member Author

Oh, 1.65 also includes generic associated types (GATs). #908 👀

@lnicola
Copy link
Member

lnicola commented Sep 21, 2023

We should also bump rust-version in the manifest files.

@michaelkirk
Copy link
Member Author

We should also bump rust-version in the manifest files.

Good catch! Done.

@lnicola
Copy link
Member

lnicola commented Sep 21, 2023

There's also geo-postgis and maybe even others. And the error here:

error: private item shadows public glob re-export
   --> geo/src/lib.rs:206:1
    |
206 | extern crate proj;
    | ^^^^^^^^^^^^^^^^^^
    |
note: the name `proj` in the type namespace is supposed to be publicly re-exported here
   --> geo/src/lib.rs:209:9
    |
209 | pub use crate::algorithm::*;
    |         ^^^^^^^^^^^^^^^^^^^
note: but the private item here shadows it
   --> geo/src/lib.rs:206:1
    |
206 | extern crate proj;
    | ^^^^^^^^^^^^^^^^^^
    = note: `-D hidden-glob-reexports` implied by `-D warnings`

@lnicola
Copy link
Member

lnicola commented Sep 22, 2023

Heads-up: I'm gonna try the rebase button 😄.

@lnicola
Copy link
Member

lnicola commented Sep 22, 2023

Not sure what's up with the failing tests. cs2cs EPSG:2230 EPSG:26946 and cs2cs EPSG:4326 EPSG:2230 work fine in georust/geo-ci:proj-9.2.1-rust-1.72.

@michaelkirk
Copy link
Member Author

michaelkirk commented Sep 22, 2023

I'm not sure what's going on with the proj build.

These lines are suspicious:

proj_create: Cannot find proj.db
test algorithm::map_coords::test::test_fallible_proj ... FAILED
proj_create: no database context specified

I think that rust-1.72 is the first release on the new debian "bookworm" distro. Not sure if that's relevant. It did force me to change the libtiff dependency to something that would (I hoped) work across releases.

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once tests pass ✅

@michaelkirk
Copy link
Member Author

michaelkirk commented Sep 25, 2023

Fixed with georust/docker-images@112764c

I'm not sure what's wrong with our setup vs. debian-bookworm, but I'm happy to kick that can down the road.

@michaelkirk michaelkirk added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 44d6dc1 Sep 25, 2023
14 checks passed
@michaelkirk michaelkirk deleted the mkirk/bump-msrv branch September 25, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants