Filling out GDALDataType metadata and utility support.
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
force-pushed
the
feature/cell-type++
branch
from
3b74544
to
856541a
Compare
metasim
changed the title
GDALDataType metadata and utility support.
jdroenner
requested changes
Oct 28, 2022
|
@jdroenner Thanks for the fantastic feedback! I especially appreciate knowing that the |
lnicola
requested changes
Oct 29, 2022
metasim
force-pushed
the
feature/cell-type++
branch
from
d492cbd
to
72e110f
Compare
lnicola
approved these changes
Nov 7, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2022
318: Filling out `GDALDataType` metadata and utility support. r=metasim a=metasim - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Primarily adds `GdalTypeDescriptor` for enabling runtime inspection of `GDALDataType` properties. **Note, potentially breaking change**: `GDALDataType` is no longer `pub use` in `gdal::raster`, as `GdalType` and `GdalTypeDescriptor` sufficiently cover use cases in safe code. Still accessible via `gdal_sys::GDALDataType`. --- <img width="740" alt="image" src="https://user-images.githubusercontent.com/131013/197398449-e0c1f448-87ee-498f-b1c2-33625b08c653.png"> Co-authored-by: Simeon H.K. Fitch <fitch@astraea.io>
|
Build failed: |
jdroenner
requested changes
Nov 7, 2022
metasim
commented
Nov 8, 2022
* master: fmt Added cargo alias for displaying compiler output during doctest build. Fix doctest warnings. Disallow warnings in doctests.
jdroenner
approved these changes
Nov 10, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Primarily adds
GdalTypeDescriptorfor enabling runtime inspection ofGDALDataTypeproperties.Note, potentially breaking change:
GDALDataTypeis no longerpub useingdal::raster,as
GdalTypeandGdalTypeDescriptorsufficiently cover use cases in safe code.Still accessible via
gdal_sys::GDALDataType.