Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality-of-life additions to CplStringList. #311

Merged
merged 5 commits into from Sep 25, 2022
Merged

Quality-of-life additions to CplStringList. #311

merged 5 commits into from Sep 25, 2022

Conversation

metasim
Copy link
Contributor

@metasim metasim commented Sep 20, 2022

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

New methods:

  • len
  • is_empty

New traits:

  • Debug
  • Iterator

New tests:

  • has_length
  • can_be_empty
  • invalid_keys
  • basic_list
  • debug_fmt
  • has_iterator

Also tested under:

ASAN_OPTIONS=detect_stack_use_after_return=1,sanitize-address-use-after-return=always RUSTFLAGS=-Zsanitizer=address cargo +nightly test cpl --target aarch64-apple-darwin

metasim
metasim commented Sep 21, 2022
View reviewed changes
src/utils.rs Show resolved Hide resolved
lnicola
lnicola reviewed Sep 22, 2022
View reviewed changes
src/cpl.rs Outdated Show resolved Hide resolved
lnicola
lnicola reviewed Sep 22, 2022
View reviewed changes
src/cpl.rs Outdated Show resolved Hide resolved
lnicola
lnicola reviewed Sep 22, 2022
View reviewed changes
src/cpl.rs Outdated Show resolved Hide resolved
@metasim
Copy link
Contributor Author

metasim commented Sep 25, 2022

bors r=lnicola

@bors
Copy link
Contributor

bors bot commented Sep 25, 2022

Build succeeded:

@bors bors bot merged commit ddfcee1 into georust:master Sep 25, 2022
@metasim metasim deleted the feature/cpl-string-list branch September 27, 2022 17:26
@metasim metasim mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

@ChristianBeilschmidt ChristianBeilschmidt Awaiting requested review from ChristianBeilschmidt

@jdroenner jdroenner Awaiting requested review from jdroenner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@metasim @lnicola