Added Rasterband::set_no_data accepting Option<f64>.
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
force-pushed
the
feature/no-nodata
branch
from
2081a1e
to
b53d0f9
Compare
metasim
commented
Sep 7, 2022
src/raster/rasterband.rs
Outdated
| pub fn set_no_data_value(&mut self, no_data: f64) -> Result<()> { | ||
| let rv = unsafe { gdal_sys::GDALSetRasterNoDataValue(self.c_rasterband, no_data) }; | ||
| self.set_no_data(Some(no_data)) | ||
| } |
There was a problem hiding this comment.
If backward compatibility weren't an option, I would have changed this signature of this to accept Option<f64> over creating a new method and delegating to it. Should we consider a breaking change here?
There was a problem hiding this comment.
I think it's fine to change the API, we're only on 0.13.
|
@lnicola FYI: Went with breaking change approach. |
|
bors r+ |
|
Build succeeded: |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Closes #275