Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased documentation content of README and root rustdoc page. #296

Merged
merged 1 commit into from Sep 3, 2022

Conversation

metasim
Copy link
Contributor

@metasim metasim commented Sep 1, 2022

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

I wanted to kickstart some work to level-up the documentation. Wanting to take an incremental approach, making it feel a bit less intimidating to make progress in the future. I don't see this as the only PR I do on this, just a start. All feedback welcome :).

Related:

Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great improvement! I'm not a frequent user of this crate though, so I'll wait for someone else to weigh in before merging.

Readme.md Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@jdroenner
Copy link
Member

This is really a great improvement! I agree with the incremental approach for better docs. So we should merge this PR and then add more docs later.

src/lib.rs Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@metasim metasim requested a review from lnicola September 2, 2022 18:29
@lnicola
Copy link
Member

lnicola commented Sep 2, 2022

Pro tip: when writing Markdown (or TeX, or text), it's better to keep it at one sentence/phrase per line. This makes it easier to view diffs.

CHANGES.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Clarification on C vs C++ documentation.

Update README.md

Update CHANGES.md
@lnicola
Copy link
Member

lnicola commented Sep 3, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 3, 2022

Build succeeded:

@bors bors bot merged commit a0ca31e into georust:master Sep 3, 2022
@metasim metasim deleted the feature/more-readme branch September 3, 2022 18:27
@metasim metasim mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants