Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to get owned reference to inner geometry. #274

Merged
merged 6 commits into from Jun 14, 2022

Conversation

metasim
Copy link
Contributor

@metasim metasim commented May 14, 2022

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Closes #269

src/vector/geometry.rs Outdated Show resolved Hide resolved
@metasim metasim requested a review from urschrei May 22, 2022 19:00
@metasim
Copy link
Contributor Author

metasim commented Jun 13, 2022

@urschrei Any further thoughts about this PR?

Copy link
Contributor

@rmanoka rmanoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: it's a useful API, and the PR doesn't add any new unsafe code.

* 'fix/269' of github.com:metasim/gdal: (21 commits)
  Fix formatting issues
  use match for error, try without casts to c_double
  Add functions to enumerate Drivers
  correct `method_name` in `root_group`
  add mdarray to CHANGES.md
  clippy lints
  more functionality and less memory leaks for mdarray
  gdalmd module fixes
  Temporary remove example, not sure how to fix clippy warning
  only build mdarray if gdal >3.1
  only build mdarray if gdal >3.1
  only build mdarray if gdal >3.1
  cargo fmt -- --emit files
  rustfmt
  add mdarray example
  Add test data for mdarrays
  Added basic support for mdarrays
  added mdarray
  added root_group function
  Add changes
  ...
@metasim
Copy link
Contributor Author

metasim commented Jun 14, 2022

@rmanoka FYI, build is now completing successfully.

@rmanoka
Copy link
Contributor

rmanoka commented Jun 14, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 14, 2022

Build succeeded:

@bors bors bot merged commit af69b1d into georust:master Jun 14, 2022
@metasim metasim deleted the fix/269 branch October 16, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry::get_point_vec() returns empty Vec
3 participants