Add wrapper for GDALGetRasterUnitType
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
May 12, 2022
| @@ -449,6 +449,13 @@ impl<'a> RasterBand<'a> { | |||
| Ok(RasterBand::from_c_rasterband(self.dataset, overview)) | |||
| } | |||
| } | |||
|
|
|||
| /// Return the unit of the rasterband. | |||
| /// If there is no unit, the empty string is returned. | |||
There was a problem hiding this comment.
I can't find this in the GDAL docs, can we have an assert_ne!(str_ptr, std::ptr::null()) or something like that?
There was a problem hiding this comment.
|
Wow, I love the undelimited numbers in that |
ChristianBeilschmidt
force-pushed
the
rasterband-unit
branch
from
c05e8aa
to
fec5ccc
Compare
lnicola
reviewed
May 12, 2022
| pub fn unit(&self) -> String { | ||
| let str_ptr = unsafe { gdal_sys::GDALGetRasterUnitType(self.c_rasterband) }; | ||
|
|
||
| if str_ptr.is_null() { |
If you have another file at hand with a unit, I can use it. I just got one from the osgeo gdal repo. |
No, it's fine, I was just surprised that GDAL actually parses that. |
lnicola
approved these changes
May 12, 2022
|
I'll wait a bit, then merge this, it's pretty trivial. |
|
@bors r+ |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.I've added a wrapper for
GDALGetRasterUnitTypeinto rasterband. Since I had no test file that has a unit, I added a test file from the original GDAL repo: https://github.com/OSGeo/gdal/blob/96096ae1e61b1b7afdc686ab9a00ca4fee772ba6/autotest/gdrivers/data/usgsdem/114p01_0100_deme_truncated.dem