Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.rs build is failing for 0.12.0 #268

Closed
metasim opened this issue Apr 18, 2022 · 3 comments
Closed

docs.rs build is failing for 0.12.0 #268

metasim opened this issue Apr 18, 2022 · 3 comments

Comments

@metasim
Copy link
Contributor

metasim commented Apr 18, 2022

image

Looks like some sort of linker error:

/opt/rustwide/workdir/build.rs:13: undefined reference to `GDALVersionInfo'

Build log:

https://docs.rs/crate/gdal/0.12.0/builds/494924

@metasim
Copy link
Contributor Author

metasim commented Apr 18, 2022

Perhaps DOCS_RS is no longer defined? 🤷

gdal/gdal-sys/build.rs

Lines 63 to 66 in 492e0c8

// Hardcode a prebuilt binding version while generating docs.
// Otherwise docs.rs will explode due to not actually having libgdal installed.
if std::env::var("DOCS_RS").is_ok() {
let version = Version::parse("3.2.0").expect("invalid version for docs.rs");

@rmanoka
Copy link
Contributor

rmanoka commented Apr 20, 2022

related to #240 ?

@metasim
Copy link
Contributor Author

metasim commented Sep 2, 2022

Closed by #281

@metasim metasim closed this as completed Sep 2, 2022
bors bot added a commit that referenced this issue Sep 3, 2022
296: Increased documentation content of README and root rustdoc page. r=lnicola a=metasim

- [X] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [X] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

I wanted to kickstart some work to level-up the documentation. Wanting to take an incremental approach, making it feel a bit less intimidating to make progress in the future. I don't see this as the only PR I do on this, just a start. All feedback welcome :). 

Related:
* #268
* #281

Co-authored-by: Simeon H.K. Fitch <fitch@astraea.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants