Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support reading GeoParquet with native geoarrow-based encodings #3278

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 8, 2024

Broken off from #3275 with just the read support.

Implementing the reading part of #3253

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It just need a changelog note.

Copy link
Member

@m-richards m-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as well, from my high level understanding of geoparquet/geoarrow

return coords
else:
# fixed size list
return np.asarray(arr.values).reshape(len(arr), -1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it easy to generate an input file to read so our tests cover the interleaved coordinates case? (we also miss coverage above for the 2D/3D case, but the logical is identical so I don't think that matters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So officially GeoParquet doesn't support interleaved coordinates, only separated. That's why it is not included here in the tests. In a follow-up PR, I however want to add support for converting from (Geo)Arrow (in-memory) to geopandas (#3219 is already doing the export from geopandas to geoarrow), and those code paths will be covered.

Not ideal that for now it's not covered (and I could also have just included the separated code path here), but will do that follow-up shortly.

@martinfleis martinfleis added this to the 1.0 milestone May 17, 2024
@jorisvandenbossche jorisvandenbossche merged commit df774fa into geopandas:main May 17, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants