Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: install docs dependencies from pip to avoid proj warnings #3263

Merged
merged 19 commits into from
Jun 1, 2024

Conversation

m-richards
Copy link
Member

@m-richards m-richards commented Apr 24, 2024

Closes #2683
This sidesteps the issue with proj warnings on readthedocs with mamba by installing with pip instead.

da319bb tries to just install pyproj with pip, but this also seems to produce the warning.

Edit: for some reason installing from requirements files seems to break images as martin noted below.

@m-richards m-richards changed the title See if readthedocs env from pip has no warnings DOC: install docs dependencies from pip to avoid proj warnings Apr 24, 2024
@m-richards m-richards marked this pull request as ready for review April 24, 2024 10:11
@martinfleis
Copy link
Member

For some reason, the image outputs are broken (see https://geopandas--3263.org.readthedocs.build/en/3263/docs/user_guide/mapping.html). Not sure if it is related to these changes or not...

@martinfleis martinfleis added this to the 1.0 milestone May 17, 2024
@m-richards m-richards marked this pull request as draft May 18, 2024 01:31
doc/environment.yml Outdated Show resolved Hide resolved
@martinfleis
Copy link
Member

If I am looking right, the latest version has solved it without any side issues?

@m-richards
Copy link
Member Author

Not at a computer but I thought the savefig images were still broken when I gave up but maybe I was looking at an old link

@martinfleis
Copy link
Member

All looks okay on my side at the moment. So we can probably just clean this and merge.

@m-richards m-richards marked this pull request as ready for review May 21, 2024 11:53
@m-richards
Copy link
Member Author

m-richards commented May 21, 2024

Alright, this should be good to go now. I also fixed some build warnings from https://readthedocs.org/projects/geopandas/builds/24422174/
not sure if PYDEVD_DISABLE_FILE_VALIDATION=1 is actually going to work, or if that only works as inline to a bash command.

Edit: 3 final warnings (besides the ipython debugger frozen modules warnings)

/home/docs/checkouts/readthedocs.org/user_builds/geopandas/checkouts/3263/doc/source/docs/user_guide/interactive_mapping.ipynb:13: WARNING: File not found: 'docs/reference/api/geopandas.GeoDataFrame.plot.html'
/home/docs/checkouts/readthedocs.org/user_builds/geopandas/checkouts/3263/doc/source/docs/user_guide/interactive_mapping.ipynb:13: WARNING: File not found: 'docs/reference/api/geopandas.GeoDataFrame.explore.html'
/home/docs/checkouts/readthedocs.org/user_builds/geopandas/checkouts/3263/doc/source/gallery/choropleths.ipynb:: ERROR: Anonymous hyperlink mismatch: 2 references but 1 targets.

The first two seem to work despite the errors - I guess they're relative paths into the outputs of sphinx build.

The third is some missing hyperlinks (and also a broken image) in the first cell of the choropleths notebook which is super old predates #1731 which is as far back as I looked. @martinfleis you've probably got the best idea of which icon / what webpage to link to for pysal / or we just replace the old stuff with a new link just to pysal.org

"https://python-visualization.github.io/folium/",
"https://python-visualization.github.io/folium/objects.inv",
"https://python-visualization.github.io/folium/latest",
"https://python-visualization.github.io/folium/latest/objects.inv",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the objects.inv isn't present for the stable tag, isn't present at the redirect without a tag either.

pre_build:
- PYDEVD_DISABLE_FILE_VALIDATION=1
post_build:
- mamba list
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to be here, but it's not exactly harmful, and might come in handy in future

Comment on lines 42 to 43
# pyproj deps via geopandas conda-forge, can be moved once pyproj
# is no longer a required dep on conda forge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will happen. We have geopandas-base on conda-forge that does not pull pyproj but geopandas does and I am not aware of discussions that it should change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have geopandas-base on conda-forge that does not pull pyproj

I'm not sure that's right - I opened #3293 because as I understand it geopandas-base does require pyproj right now.

I thought these both depended on geopandas-base only, but having a look again it seems they depend on geopandas directly, so I'll remove this comment then.

@martinfleis martinfleis merged commit 477198b into geopandas:main Jun 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: printed PROJ ERROR log in online docs
2 participants