Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added robust keyword to plotting to better handle high dynamic range #3188

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

leonfoks
Copy link

This sets vmin and vmax to the 2nd and 98th percentile of the values similar to xarray's robust keyword.
colourbar is extended in both directions same as xarray
overwrites user defined vmin and vmax if provided.

@leonfoks
Copy link
Author

Can someone please point me in the right direction? Im looking at the failed lint and im not sure what exactly is wrong!

@m-richards
Copy link
Member

Hey @leonfoks generally it is a good idea to first open an issue to discuss the feature you would like to add before jumping in and creating a PR. As a generic library we have to be careful not to add everything possible to our plotting functions, or we end up with an unwieldy API. So it's good to get to get support from maintainers before going to the trouble of creating a whole PR.

In this case though, I think robust is probably a worthwhile inclusion.

In terms of the linting specifically, you might want to have a look here: https://geopandas.org/en/latest/community/contributing.html#style-guide-linting,
in particular, the step for installing pre-commit - as it's the easiest way to make sure the linting is in sync with our requirements (but you can also invoke black and ruff directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants